search

jvm-profiling-tools / perf-map-agent

A java agent to generate method mappings to use with the linux `perf` tool
GNU General Public License v2.0
1.64k stars 260 forks source link

Fix compile warnings when compiling on latest OSX with clang #65

Closed normanmaurer closed 6 years ago

normanmaurer commented 6 years ago

@jrudolph @nitsanw this makes clang a bit more happy :)

nitsanw commented 6 years ago

I'm really sorry, the main blocker for me is that I do not have a MacOS env to test with. I assume you're done your testing and are happy with it. It would be good if we can have the CI working so that at the very least some sanity checks are in place. I'll see if I can resolve that and if the build passes for this on Mac I think it would be safe to merge (I think its safe enough anyhow, but would like to have the pipeline work).

normanmaurer commented 6 years ago

@nitsanw @jrudolph so how can we move this forward ?

nitsanw commented 6 years ago

please rebase so CI re-runs your PR, then I'll merge it. Sorry it took so long for my guilt to overcome me, I'm growing resistant to it...

jrudolph commented 6 years ago

I don't the CI ever worked. Or did it?

nitsanw commented 6 years ago

just fixed it ;-)

normanmaurer commented 6 years ago

@nitsanw woot... build completed :)

nitsanw commented 6 years ago

and indeed, no warnings! thanks @normanmaurer

normanmaurer commented 6 years ago

@nitsanw <3