search

jvm-profiling-tools / perf-map-agent

A java agent to generate method mappings to use with the linux `perf` tool
GNU General Public License v2.0
1.64k stars 260 forks source link

JDK 10 compatibility. #71

Closed gierlachg closed 4 years ago

gierlachg commented 6 years ago

Not sure if that's the best way to achieve this - Runtime component does not require javah which is missing in JDK 10.

Slach commented 5 years ago

Hello @jrudolph Could anybody review this PR ?

jrudolph commented 5 years ago

I don't think it will work because the JRE doesn't include the necessary header files. The problem seems to be solved in recent cmake versions (see https://gitlab.kitware.com/cmake/cmake/merge_requests/1637). Can you see if upgrading cmake helps?

Supagoat commented 4 years ago

I ran into this problem and created a javah bash script that just executes: javac -h "$@"

The build was successful, but I haven't tested perfmap yet.

jrudolph commented 4 years ago

I tried this and it doesn't help. As explained above the problem is with an outdated cmake version. More recent versions do work.

jrudolph commented 4 years ago

You probably need cmake 3.11.2 at least to build on Java >= 10