jvm-repo-rebuild / reproducible-central

Reproducible Central: rebuild instructions for artifacts published to (Maven) Central Repository
103 stars 46 forks source link

Add org.apache.royale #117

Open yishayw opened 1 year ago

yishayw commented 1 year ago

Hi,

Version 0.9.10 of org.apache.royale is reproducible. What steps do I need to take to add it to your list?

Thanks

hboutemy commented 1 year ago

i can work on it: is it https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/README.md ? if not, please provide at least a pointer to the Git repo

yishayw commented 1 year ago

Yes. The project actually consists of 3 different repos: the compiler you mentioned, the application framework at apache/royale-asjs: Apache Royale ASJS (github.com)https://github.com/apache/royale-asjs and the so called 'typedefs' at apache/royale-typedefs: Apache Royale TypeDefs (github.com)https://github.com/apache/royale-typedefs

They all get released together and are tested for binary reproducibility.

Out of the three only the compiler is coded in Java and it is used in other projects as well, so that might be the best fit out of the three for this list if you had to choose.

Thanks!

[https://opengraph.githubassets.com/8b4643e85cbac0f98bcd5362e6f93afdca2d6e3932d17b74dd06875984f68c35/apache/royale-asjs]https://github.com/apache/royale-asjs GitHub - apache/royale-asjs: Apache Royale ASJShttps://github.com/apache/royale-asjs Apache Royale ASJS. Contribute to apache/royale-asjs development by creating an account on GitHub. github.com


From: Hervé Boutemy @.> Sent: Tuesday, June 13, 2023 2:10 PM To: jvm-repo-rebuild/reproducible-central @.> Cc: yishayw @.>; Author @.> Subject: Re: [jvm-repo-rebuild/reproducible-central] Add org.apache.royale (Issue #117)

i can work on it: is it https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/README.md ? if not, please provide at least a pointer to the Git repo

— Reply to this email directly, view it on GitHubhttps://github.com/jvm-repo-rebuild/reproducible-central/issues/117#issuecomment-1589084443, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAQBE7PNYGMTTMJVBMXURTDXLBDA7ANCNFSM6AAAAAAZDEKNUY. You are receiving this because you authored the thread.Message ID: @.***>

hboutemy commented 1 year ago

as you can see, I tried to rebuild the compiler and found differences between my local build and the reference build from Maven Central: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/royale-maven-plugin-0.9.10.diffoscope

perhaps you can help me improve the buildspec if some issues are cause by inaccurate build instructions: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/royale-compiler-0.9.10.buildspec

to rebuild as Reproducible Central does, run ./rebuild.sh content/org/apache/royale/compiler/royale-compiler-0.9.10.buildspec

yishayw commented 1 year ago

I'll discuss this with the team and see if we can figure this out.

yishayw commented 1 year ago

It turns out we do not check src or doc jars for reproducibility, just the binary ones. Also, you are missing "option-with-swf" in the build parameters.