jvmahon
commented
3 years ago Can you change your number format to use the US-style decimal as the separator -- i.e., use 23.5.
=============== For anybody who wants to help with a fix that works with the comma-separated decimal numbers, here's what I think is happening . . .
There's a code file called "Setup Listerner.js" in the "lib" directory. The main function of this code is to listen for changes coming over the telnet port. HomeSeer generally formats the data as a comma separated string of parameters. A portion of that code (lines 72-83), reporduced, splits the string into individual parameters using the comma (line 74).
case(thisUpdate.startsWith("DC")): // Handle received data
{
myData = new HSData( thisUpdate.split(","));
//Only need to do an update if there is HomeKit data associated with it!, Which occurs if the notifyObjects array is not undefined.
if( (HomeSeerData.HomeSeerDevices[myData.ref]) && (HomeSeerData.HomeSeerDevices[myData.ref].notifyObjects !== undefined) )
{
globals.log(`HomeSeer device: ${cyan(myData.ref)}: new value ${cyan(myData.newValue)}, had old value ${cyan(myData.oldValue)}` );
HomeSeerData.processReceivedData(myData.ref, parseFloat(myData.newValue))
}
break;
};I never considered non-US numbers, so a number like "23,5" arriving on that port will be split as if it is two parameters.
I'm not really doing much work on this code anymore -- I'll still help and answer questions on github, but I am no longer using HomeSeer so I can't do much to experimenting / testing, but if anybody has a solution that they want to propose and have tested - and can confirm it works both on "." and "," separated decimal numbers - please post as a pull request
mbaastrup
I have a thermostat running in test, its working as such. It ref'ed to different devices in a parent-child device structure in HS4. When I change the temp from the HomeKit GUI to a whole number (e.g. 23) it set the temp, log entry in both Homebridge and HS4 is good. When I change the temp from the HomeKit GUI to a half degree value (e.g. 23,5) the log entry in Homebridge show no change When I change the temp directly in HS4 from 23 to 23,5 the value is set in HS so it seems the HS4 device works fine but is is not picked up by Homebridge.
/MB