Add Favorite Setting Capability?

knedd commented 2 years ago

As you know, there is another version of this app "homebridge-neosmarshades" that includes the ability to leverage a favorite setting, which has default at 25%. Unfortunately the "homebridge-neosmartshades" app was published two years ago has a major error that will not allow it to load within Homebridge.

Would it be possible to add the "favorite" capability to this more recent version of "homebridge-smartshades" app as well? I use the "favorite" function to close blinds that are already in the down position.

This would be very helpful and greatly appreciated.

jvmahon commented 2 years ago

I think so. Some questions.

In your experience, is it hard to exactly "hit" the 25%? I.e., should I have a range like 15-35% so the user doesn't have to be so precise with the slider.

Does it make sense to also do this around the 75% range? I.e., anything between 65-85% also sets to the "favorite"

knedd commented 2 years ago

Thanks for taking this on.

For me, hitting an exact percentage has not been an issue as Homekit presents a slider for shades. However, I do like the idea of a range, which would make it easier. Perhaps something like 90-95%, as the opening of the blind occurs just before it is completely lowered?

knedd commented 2 years ago

Were my answers helpful?

jvmahon commented 2 years ago

Yes. As an update - I plan to revise the code so that you can enable or disable a "favorites" feature on a per-device basis. I'm also revising so that if one uses a "no" code motor, you can get a "true" 0 - 100% setting (its the only one of the NEO-supported motors that allows this. I've started working on the updates, but it will probably be a week or so before I get this done (quite busy with my 'real' job at the moment.).

knedd commented 2 years ago

This will be a great update. Thank you very much for your efforts!

knedd commented 2 years ago

Any progress on your update?

jvmahon commented 2 years ago

No. It may be a while - my "real" work is keeping me too busy to look at this right now.

knedd commented 2 years ago

Is this still on your radar?

knedd commented 2 years ago

Sorry to bother you again, but do you still plan on doing this?

jvmahon commented 2 years ago

I've kept this comment open with the plan that I'll eventually get it done (I generally keep comments open until I make a final fix / no-go decision). Unfortunately, work has been several months of too busy schedules, so I can't predict when.

jvmahon commented 2 years ago

I've published it as a beta for you to test.

To install the Beta,

From the Config-ui-x interface, select ...

Then select the beta version

I haven't had time to test this, so please let me know if it works.

kmnedd commented 2 years ago

Thank you! What setting is required to enable a favorite?KevinSent via iPhoneOn Oct 27, 2022, at 06:10, jvmahon @.***> wrote: I've published it as a beta for you to test. To install the Beta,

From the Config-ui-x interface, select ...

Then select the beta version

I haven't had time to test this, so please let me know if it works.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

kmnedd commented 2 years ago

I tested the beta and it works like a charm! The favorite feature works as we discussed. KevinSent via iPhoneOn Oct 27, 2022, at 06:10, jvmahon @.***> wrote: I've published it as a beta for you to test. To install the Beta,

From the Config-ui-x interface, select ...

Then select the beta version

I haven't had time to test this, so please let me know if it works.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

jvmahon commented 2 years ago

Thanks for testing. Its now published as a "regular" version (1.0.7)

EdrinP commented 2 years ago

Thanks for adding the favorite feature! I've also tested this with 1.0.7.

One observation: If asking Siri to "set the blind to 25%", it works great and moves to the Favorite position (as specified in Neo app for each shade).

If instead we drag the slider in the Home app accessory detail view (long-press the tile) it is not as precise -- shade starts moving a bit as we get closer to 25% then stops moving. Does not go to favorite position. I see you're using only 24-26% range, and maybe increasing it a bit (20-30?) may help. Not a big deal as I'd rarely use the slider, in favor of Siri or automations to ask for exactly 25%.

jvmahon / homebridge-smartshades

Add Favorite Setting Capability? #13