search

jvns / dnspeep

spy on the DNS queries your computer is making
MIT License
1.35k stars 57 forks source link

Support SVCB and HTTPS resource records #25

Closed l0s closed 2 years ago

l0s commented 2 years ago

This adds support for record types 64 and 65, service binding and HTTPS. This required upgrading to the latest version of dns-message-parser and bumping the minor revision of bytes.

Resolves: #7

jvns commented 2 years ago

Thanks, I made a PR (#24) for this a couple of weeks ago but didn't merge it :). Do you understand what the https field in the SVCB record type means? I think the reason I didn't merge #24 was that I wasn't sure how to format the https field.

l0s commented 2 years ago

@jvns because an SVCB and HTTPS record are essentially the same, there is only one struct used for the two resource records types. The https field just helps to distinguish the two. It's needed internally to dns-message-parser. But in dnspeep, we already know the resource record type.

jvns commented 2 years ago

That makes sense, thanks!