search

jvolkman / intellij-protobuf-editor

Protocol Buffers for IntelliJ-based IDEs
Apache License 2.0
122 stars 15 forks source link

Support .pbtxt extension as well #62

Closed garrett-bernstein-invitae closed 3 years ago

garrett-bernstein-invitae commented 3 years ago

Super helpful plugin, thanks.

Adding support for recognizing .pbtxt files in addition to .pb files would be great, since the former is intended to be the human-readable format.

jvolkman commented 3 years ago

We surveyed usage within google when I was still there and .pb and .textproto were the leading extensions. At that point there were no standards (for extensions or the text format itself), but we defined .textproto as the default going forward. The plugin did support a bunch of extensions at some point, including .pbtxt, but I removed a bunch that weren't heavily used.

I'm not opposed to adding another extension if it's heavily used. Although it looks like Tensor flow uses .pb for binary files which would also conflict.

You can also add a custom extension association in the editor preferences.

garrett-bernstein-invitae commented 3 years ago

Ok, that makes sense. I'm happy to just stick with .textproto if that's the prevailing extension. Thanks.