search

jvolkman / rules_pycross

Bazel + Python rules for cross-platform external dependencies
Apache License 2.0
59 stars 22 forks source link

fix: Add imports to allow experimental_python_import_all_repositories #86

Closed ewianda closed 5 months ago

ewianda commented 6 months ago

This fixes breakage for users of this repository when --experimental_python_import_all_repositories=false is set, which the Bazel team would like to do in https://github.com/bazelbuild/bazel/issues/2636.

See also https://github.com/bazelbuild/rules_python/issues/792

Without this change, users get the error:.

runfiles/rules_pycross/pycross/private/tools/wheel_installer.py", line 14, in <module>
    from pycross.private.tools import namespace_pkgs
ModuleNotFoundError: No module named 'pycross'
jvolkman commented 6 months ago

Thanks! I'll need to investigate this test failure.

ewianda commented 5 months ago

Hi @jvolkman was wondering if you had a chance to look at this.

jvolkman commented 5 months ago

I fixed the test issue in main, so I'll merge this now.