User model does not appropriately ensure the existence of a Rating association

jvoss / artccmgr

ARTCC Manager is a full featured VATUSA/VATSIM ARTCC website and management platform.

GNU General Public License v3.0

0 stars 2 forks source link

User model does not appropriately ensure the existence of a Rating association #13

Closed jvoss closed 6 years ago

jvoss commented 6 years ago

In gitlab by @jvoss on Oct 27, 2017, 15:42

When validating a user, the existence of a Rating is not validated before attempting to save a user. This results in Rollback when the User object is attempted to save to the database due to the non-null field for rating_id.

A simple validating needs to be added to check for the presence on a rating. Spec needs updated to check for this as well.

jvoss commented 6 years ago

In gitlab by @jvoss on Oct 27, 2017, 17:11

mentioned in commit 78eadbb9aac49c4d6ba55ecddf52b48a21758f76

jvoss commented 6 years ago

In gitlab by @jvoss on Oct 27, 2017, 17:12

Fixed in 78eadbb9

jvoss commented 6 years ago

In gitlab by @jvoss on Oct 27, 2017, 17:12

closed