jvoss / artccmgr

ARTCC Manager is a full featured VATUSA/VATSIM ARTCC website and management platform.
GNU General Public License v3.0
0 stars 2 forks source link

Position callsign format bug #16

Closed jvoss closed 7 years ago

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 1, 2017, 21:38

Fix position callsign format validation to allow two letter callsigns: eg. XX_XX_CTR

Currently checks for 3 letters (XXX_XXX_XXX)

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 3, 2017, 16:46

The regular expression used to validate a position callsign is currently: /^[A-Z]{3}([A-Z0-9]{1,3})?[(FSS|CTR|APP|DEP|TWR|GND|DEL)]{3}$/

This does not match a position such as: KC_CTR

Need to do more research to see if there are any other variations that it would not match. Otherwise simply changing to the following should work: /^[A-Z]{2,3}([A-Z0-9]{1,3})?[(FSS|CTR|APP|DEP|TWR|GND|DEL)]{3}$/

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 9, 2017, 15:24

Also need to be able to support callsigns beginning with 4-letters: EIDW_APP

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 11, 2017, 15:22

created branch 16-position-callsign-format-bug

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 11, 2017, 15:48

mentioned in commit f109d3cc4aeb761d8b9ba3a7a92a666c0d82ce54

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 11, 2017, 15:49

mentioned in merge request !19

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 11, 2017, 15:51

closed via merge request !19

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 11, 2017, 15:51

closed via commit 67b47a2790b2230f0fb47c9363b23e3a3c1a5c3e

jvoss commented 7 years ago

In gitlab by @jvoss on Nov 11, 2017, 15:51

closed via commit f109d3cc4aeb761d8b9ba3a7a92a666c0d82ce54