jvparidon / lmerMultiMember

Multiple membership random effects. Wrapper around lme4::lmer and lme4::glmer.
https://jvparidon.github.io/lmerMultiMember/
MIT License
16 stars 1 forks source link

rewrote `interaction_weights()` internals, much faster now #55

Closed jvparidon closed 1 year ago

jvparidon commented 1 year ago

Rewrote interaction_weights() to use some clever indexing and a single sparse matrix multiplication, rather than nested for loops. Should be orders of magnitude faster for large datasets!

codecov-commenter commented 1 year ago

Codecov Report

Base: 97.25% // Head: 96.85% // Decreases project coverage by -0.39% :warning:

Coverage data is based on head (e94b30f) compared to base (1016383). Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================== - Coverage 97.25% 96.85% -0.40% ========================================== Files 2 2 Lines 291 286 -5 ========================================== - Hits 283 277 -6 - Misses 8 9 +1 ``` | [Impacted Files](https://codecov.io/gh/jvparidon/lmerMultiMember/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeroen+van+Paridon) | Coverage Δ | | |---|---|---| | [R/weights\_from\_vector.R](https://codecov.io/gh/jvparidon/lmerMultiMember/pull/55/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeroen+van+Paridon#diff-Ui93ZWlnaHRzX2Zyb21fdmVjdG9yLlI=) | `97.43% <93.33%> (-2.57%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeroen+van+Paridon). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeroen+van+Paridon)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.