search

jvsinghk / spacex

Front-end application which would help users list and browse all launches by SpaceX program
https://spacex-launch-programs.netlify.app/
3 stars 4 forks source link

Server Side Rendering #7

Open jvsinghk opened 3 years ago

jvsinghk commented 3 years ago

You can add SSR to this or can take my commits in the feature/server-side-rendering branch and fix it.

The initial launch programs landing page ideally should be server-side-rendered. A boilerplate to implement the Server-side rendering can be used.

devil-cyber commented 3 years ago

I would like to work on this can you assign this issue to me

jvsinghk commented 3 years ago

Sure @devil-cyber. Let me know about your approach.

devil-cyber commented 3 years ago

I think we can achive this bu using Express with babel and webpack. For our server code to work, we’ll need to bundle and transpile it, using webpack and Babel. To accomplish this. I am newbie to the world of react .

jvsinghk commented 3 years ago

Great, go ahead try out. I think it will work.

devil-cyber commented 3 years ago

Ok

On Fri, Oct 2, 2020, 11:53 PM Jasvinder Sabharwal notifications@github.com wrote:

Great, go ahead try out. I think it will work.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jvsinghk/spacex/issues/7#issuecomment-702888090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPIV6UFX6REPUOMZUFJG6LSIYLBFANCNFSM4SB643YQ .

jvsinghk commented 3 years ago

@devil-cyber are you working on this. If yes, you will have to fork this repo to make a remote copy of this on your profile. Then you can clone and commit to a new branch to open a pull request.

devil-cyber commented 3 years ago

Yes i will start tomorrow, this time i am working on some other project

On Sat, Oct 3, 2020, 12:04 AM Jasvinder Sabharwal notifications@github.com wrote:

@devil-cyber https://github.com/devil-cyber are you working on this. If yes, you will have to fork this repo to make a remote copy of this on your profile. Then you can clone and commit to a new branch to open a pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jvsinghk/spacex/issues/7#issuecomment-702892959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPIV6RGZUNFQ67XH7T7GR3SIYMJVANCNFSM4SB643YQ .

setheal commented 3 years ago

Hey, is this issue still open ?

jvsinghk commented 3 years ago

@setheal Hey, yes this issue is still open

devil-cyber commented 3 years ago

Go ahed , sorry for late but I am admitted in hospital from last night

On Sat, Oct 3, 2020, 6:27 PM Jasvinder Sabharwal notifications@github.com wrote:

@devil-cyber https://github.com/devil-cyber are you planning to contribute to this today? Unassigned you because you haven't forked yet. This issue is open for contribution. @setheal https://github.com/setheal would you like to work on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jvsinghk/spacex/issues/7#issuecomment-703099552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPIV6Q7K6ST4GXRW24SDR3SI4NTFANCNFSM4SB643YQ .

jvsinghk commented 3 years ago

@devil-cyber no worries, sorry to hear that, take care brother. Hope you get well soon.

jvsinghk commented 3 years ago

@setheal would you like to contribute to this issue?

setheal commented 3 years ago

@jvsinghk sure, I'll do it when I have a bit of time :)

setheal commented 3 years ago

@devil-cyber take care mate

jvsinghk commented 3 years ago

@setheal Sure, let me know you want me to assign it to you.

setheal commented 3 years ago

@jvsinghk You can assign it to me if it still opened

Btw, do you need to add react-router to the project ? I can make the server side configuration at the same time if needed

jvsinghk commented 3 years ago

@setheal Sure, how are you planning to use react-router in SpaceX?

setheal commented 3 years ago

@jvsinghk it's just to know if you want me to add the static router server side :) I already created my pr but don't hesitate to ask me in the future if you need help with the router :)

jvsinghk commented 3 years ago

@setheal I have used react-router in amazon-clone to add routes for different components. Here as it's the single page. I was wondering how you plan to make use of it here. Sure, can you help me understand this concept of static router server-side rendering? So, I would be able to add to my other application. I would like to learn about it.

setheal commented 3 years ago

@jvsinghk sure ! It's just a limitation of react-router, you need to use a different router on the server (called StaticRouter). I'm usually putting the StaticRouter around my top component on the server and a BrowserRouter in the root file of the client. This way you can handle the routes server side and client side :)

jvsinghk commented 3 years ago

@setheal great! Thanks for the simple straight explanation. Will use the StaticRouter and BrowserRouter in the coming and existing projects. If possible, please add a resource to which can help me learn it's implementation.

setheal commented 3 years ago

@jvsinghk Sure ! You can check this 3 links:

Don't hesitate to contact me if you need any help :)

jvsinghk commented 3 years ago

@setheal Awesome! Sure, Tysm for the resources :)