Don't hardcode prefix on version string

jw3 / example-daffodil-vscode

A VS Code extension for DFDL with Daffodil

Apache License 2.0

2 stars 3 forks source link

Don't hardcode prefix on version string #2

Closed jw3 closed 3 years ago

jw3 commented 3 years ago

Don't prefixed user specified version with a "v", user should enter the exact version string.

jw3 commented 3 years ago

I see this is due to the prefix mismatch between the releases and the packaging.

shanedell commented 3 years ago

The PR attached will allow the user to enter in both v0.0.1 and 0.0.1 and it will work the same. If the the releases of the debugger file names to be something like daffodil-debugger-v0.0.5 then all that is need is to remove the .substring(1) attached to dapodilDebuggerVersion and now it will work with that. However for the input of task to run the debugger you string must enter a version 0.0.1 and will need to unless the zip file names end up getting changed.