Hex View Fix - Githubissues

jw3 / example-daffodil-vscode

A VS Code extension for DFDL with Daffodil

Apache License 2.0

2 stars 3 forks source link

Hex View Fix #56

Closed shanedell closed 3 years ago

shanedell commented 3 years ago

Fix issue where highlighted text and icon get stuck on a line, will now move down to the end of the file.
Update location of data hex file so it can be reopened by the user if desired.
Update extension to automatically close the hex file is already open in a visible editor, will also delete the data file if it exists, then opens the hex file once it is remade for the proper data file.
Remove setting of white text color of selection

Closes #57 , Closes #58

arosien commented 3 years ago

It would be great to get this merged and cut into a release before tomorrow's demo!

jw3 commented 3 years ago

@arosien Appears we might have an issue with Linux and XDG dirs, but it is a separate issue and not a blocker for this PR. How do these changes look on your machine?

(only mentioning because I cant easily test this PR because of the XDG isssue)

jw3 commented 3 years ago

Tracking issue with arrow drawing and highlighting in #60

arosien commented 3 years ago

@arosien Appears we might have an issue with Linux and XDG dirs, but it is a separate issue and not a blocker for this PR. How do these changes look on your machine?

(only mentioning because I cant easily test this PR because of the XDG isssue)

I pulled down the branch, but discovered I don't know how to launch the extension. I think I might need to install something locally?

> Executing task: yarn run watch <

yarn run v1.21.1
warning daffodil-debug@0.0.7: The engine "vscode" appears to be invalid.
$ webpack --watch --devtool nosources-source-map --info-verbosity verbose --config ./build/extension.webpack.config.js
/bin/sh: webpack: command not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The terminal process "/bin/zsh '-c', 'yarn run watch'" terminated with exit code: 127.

Terminal will be reused by tasks, press any key to close it.

jw3 commented 3 years ago

The process I use is

Open the root project in VS Code
Run yarn from terminal to update deps
Press F5 or go to the debug panel and run the Extension profile

arosien commented 3 years ago

The process I use is

Open the root project in VS Code

Run yarn from terminal to update deps

Press F5 or go to the debug panel and run the Extension profile

Ah, thanks, I was missing the yarn step. Will add to the README.

shanedell commented 3 years ago

Hey guys, got some downtime on vacation and saw the comments so I pushed a out a v0.0.7-alpha release that will have the changes there. this will just a temp release till the demo is over then can be deleted or if everything works okay for Adam, and its some linux issue or something, then you can delete it, merge and re-release a v0.0.8 Also good luck tomorrow!!