search

jw3 / example-daffodil-vscode

A VS Code extension for DFDL with Daffodil
Apache License 2.0
2 stars 3 forks source link

Determine JRE requirements and document in the installation instructions #94

Closed jw3 closed 2 years ago

jw3 commented 3 years ago

I assume >= 1.8 ? Should verify.

jw3 commented 3 years ago

User reported a NoSuchMethod exception on Path.of.

Path.of was added at Java 11.

User is running Java 8.

jw3 commented 3 years ago

I tried passing -source 11, -target 8 to javac, figured compile would fail, it didnt, but did fail at runtime again.

arosien commented 3 years ago

I think this is a bug in Scala for JVM's before version 9: https://github.com/scala/bug/issues/2034. Can you try a newer version of the JVM (>8)?

image

jw3 commented 3 years ago

Cleaned up all usage of > JDK 8 features. The above error is the next in the sequence of errors.

jw3 commented 3 years ago

Looking for the minimum java for https://github.com/microsoft/java-debug...

In https://github.com/redhat-developer/vscode-java

Download and install a recent Java Development Kit (latest Java 11 is the current minimum requirement).

arosien commented 3 years ago

Looking for the minimum java for https://github.com/microsoft/java-debug...

In https://github.com/redhat-developer/vscode-java

Download and install a recent Java Development Kit (latest Java 11 is the current minimum requirement).

Is https://github.com/redhat-developer/vscode-java a transitive dependency?

jw3 commented 3 years ago

No, but we have explicit depend on java-debug.

Looks like java-debug minimum is 11, but I didnt see it explicitly stated anywhere else.

arosien commented 3 years ago

java-debug appears to require 8: https://github.com/microsoft/java-debug/blob/main/com.microsoft.java.debug.core/pom.xml#L31

I think the problem is the "Malformed class name" is a Scala + JDK bug that requires JDK > 8.

jw3 commented 3 years ago

Ok, should test on 9 so it can be documented accurately.

It's unfortunate though Daffodil is at 1.8 and this will be > than that.

arosien commented 3 years ago

I can restructure the Scala code to avoid the bug, but it's not a 1-day job.

jw3 commented 3 years ago

It would be nice, with that fix and the couple of changes to drop the > 1.8 features we can go back to 1.8.

For now we can push ahead with 0.1.0 prep and just say support back to 1.8 is coming, but is WIP.

arosien commented 2 years ago

JRE 11 is documented as required. Subsequent work filed at #136.