jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

Drop optional dependency #164

Open ParadaCarleton opened 3 years ago

ParadaCarleton commented 3 years ago

The single line:

setindex(a::StaticArrays.StaticArray, args...) =
            Base.setindex(a, args...)

Makes up most of the package's compile time; it could easily be moved to StaticArrays.jl, avoiding the cost of having to use Requires.jl.

jw3126 commented 3 years ago

I would love to drop this, but it is not as easy as you think. It would require a change in base, see https://github.com/JuliaLang/julia/pull/33495 If you want this, it would be awesome if you could revive that Base PR.

jw3126 commented 2 years ago

mostly solved by #174