search

jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

Remove type parameters from == methods of IndexLens and CompositeLens #166

Closed phipsgabler closed 2 years ago

phipsgabler commented 2 years ago

Fixes #165.

I'm not quite sure whether this is considered breaking; it changes behaviour of equality for some of the methods...?

jw3126 commented 2 years ago

I'm not quite sure whether this is considered breaking; it changes behaviour of equality for some of the methods...?

Yeah to me it is a bug fix, but the interpretation that this changes behavior of equality is also valid. I don't feel strongly, but since we need a decision, let's make it a patch release.

jw3126 commented 2 years ago

Thanks and sorry for the delay!