search

jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

Add Invalidations.yml [ci skip] [skip tests] #177

Closed ranocha closed 2 years ago

ranocha commented 2 years ago

This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.

See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29

jw3126 commented 2 years ago

Thanks a lot @ranocha for hunting down invalidation and making sure they don't come back. You are doing a great service to the community. I have a question, I would like to run this action on this branch, before merging. How to manually trigger that?

ranocha commented 2 years ago

In SciML, we decided to skip CI for this (since we needed to update ~100 repos). I changed the commit message here to let CI run.

ranocha commented 2 years ago

Thus, you should approve workflow runs for this PR and the new GitHub action should run, too.