search

jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

Generate body of constructor from given expr #18

Closed tkf closed 6 years ago

tkf commented 6 years ago

suggestion for #17

codecov-io commented 6 years ago

Codecov Report

Merging #18 into settable will increase coverage by 0.09%. The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##           settable      #18      +/-   ##
============================================
+ Coverage     86.47%   86.56%   +0.09%     
============================================
  Files             5        5              
  Lines           170      201      +31     
============================================
+ Hits            147      174      +27     
- Misses           23       27       +4
Impacted Files Coverage Δ
src/macrotools.jl 81.81% <100%> (-1.91%) :arrow_down:
src/lens.jl 83.33% <50%> (-1.58%) :arrow_down:
src/settable.jl 93.02% <91.89%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a92564e...275ab4d. Read the comment docs.

jw3126 commented 6 years ago

I think this looks good! We should merge it into the settable branch.

tkf commented 6 years ago

If you are fine with the change for using MacroTools.flatten, please go ahead and merge.