search

jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

Fix some tests and suppress warnings in Julia 0.7 #31

Closed tkf closed 6 years ago

tkf commented 6 years ago

First two commits for make test working. The rest is for suppressing deprecated warnings.

codecov-io commented 6 years ago

Codecov Report

Merging #31 into master will increase coverage by 2.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   94.02%   96.09%   +2.06%     
==========================================
  Files           5        4       -1     
  Lines         201      205       +4     
==========================================
+ Hits          189      197       +8     
+ Misses         12        8       -4
Impacted Files Coverage Δ
src/settable.jl 98.38% <100%> (+0.02%) :arrow_up:
src/sugar.jl 94.44% <0%> (+0.44%) :arrow_up:
src/macrotools.jl 90.9% <0%> (+6.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d661e8...47bcc7d. Read the comment docs.

jw3126 commented 6 years ago

Thanks for doing this! Off topic: I am curious what functionality from this package you are actually using. Personally I only use it to manipulate immutable types and never used it to do actual mutations (e.g. v =[1]; @set! v[1]=2). Initially I thought it was useful for generic programming that supports immutable and mutable types simultaneously. But I never needed it in practice. OTOH I implement custom lenses from time to time and then the MutationPolicy machinery just adds annoying complexity. I am thinking about removing it, do you have an opinion about that?