search

jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

Build documents in test phase #41

Closed tkf closed 6 years ago

tkf commented 6 years ago

Hi, thanks for the new release! :tada:

Looking at the release build, I just noticed that the documents are not updated because Documenter was silently failing. This is not great that we don't notice when documents are broken. So I suggest to build it in the test phase and mark it as failure if documents are broken.

codecov-io commented 6 years ago

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #41   +/-   ##
======================================
  Coverage    97.6%   97.6%           
======================================
  Files           3       3           
  Lines         125     125           
======================================
  Hits          122     122           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d45e8f...2fe4342. Read the comment docs.

jw3126 commented 6 years ago

Should this be merged, or is there something left to do?

tkf commented 6 years ago

Yes, it's ready for merge.