search

jw3126 / Setfield.jl

Update deeply nested immutable structs.
Other
167 stars 17 forks source link

use ConstructionBase #91

Closed jw3126 closed 5 years ago

jw3126 commented 5 years ago

@tkf Do you know why CI fails? Locally I can ]add ConstructionBase just fine. Does Travis some magic caching?

tkf commented 5 years ago

I think it's working https://travis-ci.org/jw3126/Setfield.jl/builds/595455069 (click continuous-integration/travis-ci/pr above the merge button)? If you are looking at continuous-integration/travis-ci/push, that's the CI for this branch as-is built when you pushed, different from the one you can restart via close-then-open.

jw3126 commented 5 years ago

Ah I see, thanks for explaining.

tkf commented 5 years ago

image

You can also click this right-top Restart build button.

jw3126 commented 5 years ago

@tkf I would like to tag a release, any objections?

tkf commented 5 years ago

I think it's good to go. FYI, testing Kaleido with Setfield 0.5 worked: https://github.com/tkf/Kaleido.jl/pull/8

jw3126 commented 5 years ago

@JuliaRegistrator register

JuliaRegistrator commented 5 years ago

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.