Closed briochemc closed 3 years ago
Merging #35 (c4228a5) into master (d2a11d8) will decrease coverage by
1.02%
. The diff coverage is86.20%
.
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 84.14% 83.11% -1.03%
==========================================
Files 1 1
Lines 82 77 -5
==========================================
- Hits 69 64 -5
Misses 13 13
Impacted Files | Coverage Δ | |
---|---|---|
src/UnitfulRecipes.jl | 83.11% <86.20%> (-1.03%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 386112f...c4228a5. Read the comment docs.
I'd like to add a test with LaTeXStrings, but this PR ends up turning labels into things like L"text $math$ (unit)" and the GR backend does not work well with these (yet?). Maybe this is worth an issue on Plots.jl?
Great feature!
I'd like to add a test with LaTeXStrings, but this PR ends up turning labels into things like L"text $math$ (unit)" and the GR backend does not work well with these (yet?). Maybe this is worth an issue on Plots.
Yeah, I think reporting this does not hurt. Things we could do on our side is use a different backend and maybe add a few unit tests, that just look at RecipesBase.apply_recipe
.
OK, I don't think these tests are too important either, and we can come back to it whenever (if ever?) Plots fixes the LaTeXStrings issue :)
This PR "extends" the types of labels from
String
toAbstractString
, so that then one can use, e.g., aLaTeXString
as a label. See this recent discourse post.With that PR, the following MWE:
outputs