search

jw3126 / UnitfulRecipes.jl

Plots.jl recipes for Unitful.jl arrays
MIT License
37 stars 10 forks source link

Support units in clim (colorbar limits) #59

Closed JeffFessler closed 3 years ago

JeffFessler commented 3 years ago

This addresses #57 and #58.

Please check carefully my work on #58 because it was tricky to me. It seems that plot(rand(5,4)) and heatmap(rand(5,4)) both have Matrix arguments. So I suspect that we need may need separate recipes for plot and for heatmap/surface/others? but I don't know enough about recipes to be confident in my solution.

codecov-commenter commented 3 years ago

Codecov Report

Merging #59 (3018a89) into master (d0508b7) will increase coverage by 0.95%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   85.71%   86.66%   +0.95%     
==========================================
  Files           1        1              
  Lines          91      105      +14     
==========================================
+ Hits           78       91      +13     
- Misses         13       14       +1
Impacted Files Coverage Δ
src/UnitfulRecipes.jl 86.66% <92.85%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6cfd83...3018a89. Read the comment docs.

JeffFessler commented 3 years ago

@jw3126 should "Moar" be "More" runtests.jl ? I could fix that too here but unsure.

jw3126 commented 3 years ago

@JeffFessler if you need an immediate release, you can bump the version.

JeffFessler commented 3 years ago

oops, thought i did that already! done - thanks!

JeffFessler commented 3 years ago

LGTM. Thanks for the help.