search

jw3126 / UnitfulRecipes.jl

Plots.jl recipes for Unitful.jl arrays
MIT License
37 stars 10 forks source link

Fix adding unit from empty plot #61

Closed briochemc closed 3 years ago

briochemc commented 3 years ago

Fixes #60?

I think I fixed it by changing "use the existing label if the subplot already exists" to "use the existing label if the subplot already exists AND at least one series already exists inside of it".

Will let the docs deploy and check what it looks like :)

briochemc commented 3 years ago

Not sure why the docs fail to deploy here. I ran the doc files locally with no issue, so I'm rerunning the master branch's CI for documentation as a check and I also submitted PR #62 to maybe fix it in parallel?

gustaphe commented 3 years ago

Apart from the in-code comment, LGTM

briochemc commented 3 years ago

Code looks fine, let's wait for the preview https://jw3126.github.io/UnitfulRecipes.jl/previews/PR61

I think we need PR #62 to be merged and rebased here to actually deploy the docs and see the preview...

briochemc commented 3 years ago

OK you can now view the preview!

briochemc commented 3 years ago

I changed the comment and bumped the patch version number so I think it's ready for merge, but let me know if you spot anything!

JeffFessler commented 3 years ago

Yay! Thank you! (I never would have figured that out...)