search

jw3126 / UnitfulRecipes.jl

Plots.jl recipes for Unitful.jl arrays
MIT License
37 stars 10 forks source link

Allow for Unitful `ribbon` #66

Closed briochemc closed 3 years ago

briochemc commented 3 years ago

Fix #65?

Just added 3 lines to strip the unit of the ribbon attribute when dealing with the y axis. I think this is sufficient. Let's see how CI likes this tiny change and if ti passes I'll add an example, a test, and bump the version for a release.

PS: Locally this now works:

julia> plot(x, -x.^2 .* 1u"m", ribbon=500u"cm")   # now works

and outputs

Screen Shot 2021-08-09 at 10 36 57 am
briochemc commented 3 years ago

I think CI passes except for some unrelated Julia-nightly pkg issue.

I'll add an example and a test.

gustaphe commented 3 years ago

LGTM