jwagener-soundcloud / recorder.js

*UNMAINTAINED* JavaScript library to record audio in browsers as used in the SoundCloud Javascript SDK.
http://johannes.wagener.cc
MIT License
324 stars 142 forks source link

Fixed "chipmunk" audio issue #11

Closed lylepratt closed 12 years ago

lylepratt commented 12 years ago

This was a difficult thing to find! It took forever to figure out why my recordings would randomly sound like chipmunks, but wouldn't other times. I finally noticed that this only happened when I was using recorder.js while a page using Twilio Client was open in the same browser!

Turns out: If this library is used in conjunction with another flash library (like Twilio Client) that makes use of the microphone, and that library changes the codec to Speex, then the sampling rate will be forever stuck at "16". This causes recordings to sound like "chipmunks". Resetting the codec fixes this.

tamerzg commented 12 years ago

Yes this is it! It starts to happen whenever I open Twilio client in the browser! Any chances this get commited and that we get updated swf soon?

jwagener commented 12 years ago

just merged and compiled a new swf. let me know if there is any problem with it.

lylepratt commented 12 years ago

I've been using it in production on BetterVoicemail.com since I created the pull request. No issues so far.

jwagener commented 12 years ago

cool. thanks for the pull req and sorry for the delay!

tamerzg commented 12 years ago

Just tried it on 3 different development servers and it works fine.