jwagner / simplex-noise.js

A fast simplex noise implementation in Javascript / Typescript.
MIT License
1.61k stars 130 forks source link

feat: make sqrt constants #72

Closed dmnsgn closed 1 month ago

dmnsgn commented 1 month ago

The previous PR actually only fixed 2 of the 4 warnings in rollup. Somehow the REPL online is not reporting them (as you can see from the links in that comment earlier) although I am using the same 4.18.1 rollup version locally. So apologies for the second PR in a row, the repl wasn't enough 😕 But I have tested with a real use case now.

Here I have extracted the two sqrt calls into const which has two benefits:

jwagner commented 1 month ago

No worries, I didn't catch it either. It's a bit late now but I'll have a look later. :)

jwagner commented 1 month ago

Released in 4.0.3. Thanks again @dmnsgn. :)