jwagner / smartcrop-sharp

Node module for using smartcrop via sharp/libvips
MIT License
115 stars 14 forks source link

chore: updating sharp to 32.05 #31

Closed achepukov closed 1 year ago

achepukov commented 1 year ago

Can we update dependencies once again?

jwagner commented 1 year ago

Yes. Wondering whether it's worth to just set the peer dependency version to *. It's wrong based on semver, in the sense that changes to sharp could break smartcrop-sharp but in practice I feel like the current process is worse. There weren't any issues for something like 20 releases of sharp so far but a lot of grief because the library wasn't updated. I guess the alternative would be to automated the updating, which would at least run the tests but that's more work.

What do you think would be a good solution for the future @achepukov ? :)

achepukov commented 1 year ago

@jwagner thanks for quick merge, you Rock!

Imo it's acceptable to use *, and point to the README.md that latest tested version was x.y.z or something. I guess you'll got an issue if any, and perhaps with PR.

In terms of the best solution - I agree that it should be auto tests + version bump for every sharp release. Can I help you with that?

achepukov commented 1 year ago

@jwagner could you please release latest main?

achepukov commented 1 year ago

@jwagner I mean publish 2.0.8

achepukov commented 1 year ago

Yeah, looks like last 3 - 4 releases you did only update sharp dependencies ))) I'm going to create PR to bind sharp to *

Screenshot 2023-08-23 at 15 43 59
jwagner commented 1 year ago

I'm currently traveling, will get back to this as soon as I'm back, likely next Monday. Sorry for the delay.

achepukov commented 1 year ago

@jwagner ok, have a great trip! ) This should resolve your pain regarding sharp updates

achepukov commented 1 year ago

@jwagner may I hope for a release this week? :) Again, feel free to ask for help if anything

jwagner commented 1 year ago

Hey @achepukov thank you for your patience! I had an accident during my vacation that I'm still recovering from. I'll try to release the dependency update today and review the PR semver change later when I have a bit more spare mental capacity.

achepukov commented 1 year ago

Thanks a lot Man! Take care! 👍