Closed rluiten closed 7 years ago
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 93.47% 93.39% -0.08%
==========================================
Files 24 24
Lines 1991 1998 +7
Branches 220 220
==========================================
+ Hits 1861 1866 +5
- Misses 114 118 +4
+ Partials 16 14 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/expressive.annotations.validate.js | 78.53% <55.55%> (-0.6%) |
:x: |
src/ExpressiveAnnotations/Analysis/TypeAdapter.cs | 85.71% <ø> (+3.57%) |
:white_check_mark: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2743f6...0e5e75d. Read the comment docs.
Hi, thank you for your work! I'll take a look at this in more details as soon as I find some time.
Sorry it took so long... Thanks again for the fix, it was a bug indeed.
All good, happy it is merged :) Thanks for your library.
This only changed deserializeObject to create an array data model and populate See https://github.com/jwaliszko/ExpressiveAnnotations/issues/149 for more details.
It passes all the existing tests. I have not tried to extend the tests you have to specifically cover the case I have added though. I don't feel I have the extra time to do that at the moment.
Hope this helps.