jwaliszko / ExpressiveAnnotations

Annotation-based conditional validation library.
MIT License
351 stars 123 forks source link

Portable version #33

Open Muraad opened 10 years ago

Muraad commented 10 years ago

Hi, thanks for this great library! I´m working on a portable version that can be used with Xamarin and mobile products. So there is no System.ComponentModel.DataAnnotations and the Reflection stuff is a little bit different. I´v made everything portable with conditional building. And all (shared) files in the PCL version are just links to the files in the normal project. I will write some Validator that can be used in a portable app/library when i have more time. I´v created a PCL version of the unit tests too. Both PORTABLE and non portable unit tests are all working fine. If you like it would be nice if you could merge it with your branch or make a new one. I try to keep up with your master branch. It would be more easier if the #if #endifs would be in your master as well. Without i have a lot of merge conflicts that must be fixed manually.

Greetings Muraad

jwaliszko commented 10 years ago

Hi, thanks for information. It's nice to hear that you like it and thanks for your work. Sure I'd like to take a look at that. As soon as I find some free time I'll go through it.

Best reagrds, /Jarek

Muraad commented 10 years ago

Super thanks! Muraad

jwaliszko commented 8 years ago

Please excuse not being active in this thread for over a year. I had no experience in PCLs and didn't fully understand whether PCL will be useful without the existence of System.ComponentModel.DataAnnotations on so many platforms: https://msdn.microsoft.com/en-us/library/gg597391(v=vs.110).aspx. Just recently I've started to learn about portable libraries. I've went through couple of various sources like:

I'm still not fully convinced of how the most appropriate approach should look like. I've also took a look here: https://github.com/ryanhorath/PortableDataAnnotations. Despite the benefits of defining the entire surface area I think this approach would be too much for EA.

Treat this comment just as a brief note. If you have any concerns and still would like to share, put it here please.

Thanks