search

jwallet / spy-spotify

🎤 Records Spotify to mp3 without ads and adds media tags to the files 🎵
https://jwallet.github.io/spy-spotify/
MIT License
2.1k stars 139 forks source link

inconsistent Bitrates #396

Open shane0168 opened 2 years ago

shane0168 commented 2 years ago

What is the bug ?

A clear and concise description of what the bug is. Steps to reproduce the behavior or describe the expected behavior: I'm getting inconsistent bitrates on downloads. I'm looking for 320. The quality still is great. I just feel like something is going wrong with my setup. Track used Spotify track/playlist used : https://open.spotify.com/search https://open.spotify.com/playlist/37FBOW5egc2XyHSn65LqW0?si=7e9dbf07927c46b4 Screenshots If applicable, add screenshots to help explain your problem. image image image

supsm commented 2 years ago

I don't think this is a bug. 320 kbps is the maximum bitrate, and some sections in songs simply don't contain enough date to use the entire 320 kbps. Variation is natural, and there doesn't seem to be anything wrong with your setup.

WaldoDJ commented 2 years ago

Hi, im new with Spytify, thame thing. Hi see that MP3 is in VBR encoder Can set to CBR 320?

jwallet commented 2 years ago

using ABR https://github.com/Corey-M/NAudio.Lame/blob/master/LameDLLWrap/LAMEPreset.cs this is normal behaviour

pr8x commented 1 year ago

@jwallet Would it be possible to add an option to conoltr whether ABR, VBR or CBR is used? Different people have different preferences and I would personally prefer CBR.

jwallet commented 1 year ago

I will reopen it since many people on reddit have an issue with that, but I think it's useless. It goes up to 320kbps but when there are silence they are no data so it's normal to have less that the maximum, unless you record a constant song. So it will now always reach the set bitrate because silence will be recorded. just know they won't be better quality because you see a higher final bitrate.

WaldoDJ commented 1 year ago

Hi, Im DJ, the standar today is 320 CBR o FLAC, VBR may produce error in Dj software, in time remain for example, and its more slow to process

supsm commented 1 year ago

This is really just a post processing issue, I agree that it's useless because ultimately users can just record full quality wav files and produce a mp3 or other format themselves. This isn't an audio processing app, it is just a recorder so I believe these features are out of scope.

jumph4x commented 4 months ago

@jwallet would appreciate this, it is not useless for a number of use cases. One big one is the latest Pioneer XDJ-RR actually seems to be having issues with VBR.

jumph4x commented 4 months ago

This is really just a post processing issue, I agree that it's useless because ultimately users can just record full quality wav files and produce a mp3 or other format themselves. This isn't an audio processing app, it is just a recorder so I believe these features are out of scope.

@supsm Recording in WAV does not allow attaching of metadata, this creates an abysmal workflow.

WaldoDJ commented 4 months ago

Hi, what about set mp3 encder in CBR? or Flac, flac support artwork and ID Tags

El lun, 22 de abr. de 2024 16:25, Denis Ivanov @.***> escribió:

This is really just a post processing issue, I agree that it's useless because ultimately users can just record full quality wav files and produce a mp3 or other format themselves. This isn't an audio processing app, it is just a recorder so I believe these features are out of scope.

@supsm https://github.com/supsm Recording in WAV does not allow attaching of metadata, this creates an abysmal workflow.

— Reply to this email directly, view it on GitHub https://github.com/jwallet/spy-spotify/issues/396#issuecomment-2070747314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGCO4AN6NISYY33CL35H3ADY6VPZTAVCNFSM5F3RV6V2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBXGA3TINZTGE2A . You are receiving this because you commented.Message ID: @.***>