jwalton512 / vim-blade

Vim syntax highlighting for Blade templates.
226 stars 37 forks source link

Integration with eclim indent #39

Closed jn-jairo closed 8 years ago

jn-jairo commented 8 years ago

The old code overwrites the indentation of eclim plugin.

With these changes, if the indentation of eclim is available, this will be used, otherwise it continues using the default indentation.

jwalton512 commented 8 years ago

hey @jn-jairo thanks for the pull request. i'm not overly familiar with eclim. would like to research a bit more before including that logic here. would you be able to add that to a separate pull request.

for the push directives, i already added to the syntax, but didn't add to the indent (as you have here).

any way to update pull request to just have the indent commit and the fix highlighting in html tags commit

jn-jairo commented 8 years ago

I did not know all the commits had appeared in the pull request. When I pull request had only commit about eclim.

This was my first pull request on github, now I see what I did wrong. I have not created a branch to separate, then the other commits appeared in this pull request.

I saw your commit, you added the syntax for @stack, @push and @endpush. Now only missing @yield, @parent and @show.

In the indent is missing @show and @empty.

In my commits I also added the indentations to @push and @section.

So let me see if I understand what I need to do:

  1. Commit about eclim should stay in a separate pull request.
  2. The pull request must be with:
    • Highlighting for @yield, @parent and @show
    • Indent to @show and @empty
    • Fix highlighting in html tags
    • Fix indent for section and push directives
  3. Remember to update the test.blade.php.

Please make sure I get it right I have to do.

jwalton512 commented 8 years ago

@jn-jairo that sounds perfect. if easier, we can close this pull request and you can open a fresh one (plus a second one for the eclim stuff)

jn-jairo commented 8 years ago

Sure, is better close this pull request, thank you.