search

jwarby / i18n-lint

`i18n-lint` is a tool for detecting possible hardcoded strings in HTML and HTML-based template source files. It can be used a CLI utility, a library or a Grunt plugin.
http://jwarby.github.io/i18n-lint/
MIT License
50 stars 20 forks source link

Suggestion: get rid of lodash #10

Closed cmajsmith closed 4 years ago

cmajsmith commented 6 years ago

Just a suggestion. I checked a code and the only method used from lodash is .last(). So may be it can be changed to a simple js array[length - 1] like lodash does itself: https://github.com/lodash/lodash/blob/master/last.js ?

jwarby commented 6 years ago

Yep it's a bit overkill to pull in the whole library just for that :laughing: feel free to submit a PR for this one too :)

cmajsmith commented 6 years ago

Great! Will do both accepted asap.