search

jwarby / jquery-awesome-cursor

jQuery plugin for using FontAwesome icons as custom CSS cursors
https://jwarby.github.io/jquery-awesome-cursor/
MIT License
179 stars 69 forks source link

fix clipping issue on abnormal size icons #20

Closed jcppman closed 8 years ago

jcppman commented 8 years ago

if the icon is too wide/tall, it wil be clipped. The new approach of finding dimensions is measuring the actual rendered icon.

closes #19

jcppman commented 8 years ago

hmm weird CI failure:

The command "eval git clone --depth=50 https://github.com/jwarby/jquery-awesome-cursor.git jwarby/jquery-awesome-cursor" failed 3 times.
jwarby commented 8 years ago

Thanks for the pull request @jcppman. My guess for the CI failure is that it's a permissions thing, probably only my account has the relevant permissions.

I'll try and take a look at the branch tonight and see if I can fix the tests (not CI). Most likely won't have time tonight though, so will probably be tomorrow instead.

Thanks again!

jwarby commented 8 years ago

The single test failure was simply because you've fixed the clipping issue and one of the "expected" output images was clipped! (test/expected/black-desktop-22.png).

jquery awesome cursor plugin test suite

I've updated the expected image for that test in a local copy of your branch, and the tests are all passing now :). I still want to add a few more tests that would fail without your fix, check it in Firefox, and actually take look at the diff before I get in merged in.

Thanks again!

jcppman commented 8 years ago

Cool, good to know that it works :)