jwcha1030 / CS416_GroupProject

2 stars 1 forks source link

editAllCollectionItemCatalogDisplayImage rescode=0 error #21

Closed jwcha1030 closed 3 years ago

jwcha1030 commented 3 years ago

I am getting a rescode error when I append new images to the previously fetched images. The input is as follows:

Screen Shot 2021-01-07 at 10 48 44 PM

(EDIT)I have mentioned in our group chat; will you add a function that checks previously added images (i.e., those that are in URL)?

Also uploading images (Object File) to an empty catalog object returns rescode=0. Below is the sequence of processes for the test:

Screen Shot 2021-01-08 at 12 28 34 AM Screen Shot 2021-01-08 at 12 30 24 AM Screen Shot 2021-01-08 at 12 31 17 AM
Habced commented 3 years ago

fixed the url issue.

for the "empty catalog object" one have you called hasCollectionItemCatalogDisplay to check if it has a catalog display? or do you want me to automatically create one if it doesn't exist (please specify which calls you want this to be applied to if you want it this way)?

jwcha1030 commented 3 years ago

once I add a catalog image the hasCollectionItemCatalogDisplay returns >0 (hence pops up an edit 360 view modal). If I remove all the images and submit, hasCollection still returns >1; hence, it does not check if the catalog object is empty. It is fine as it is.

The problem I am having is deleting item(s) and submitting an empty or updated object file via editAllCollectionItemCatalogDisplayImage() return success, but the new object file is not updated when I fetch after a refresh.

Habced commented 3 years ago

I updated the logic in editAllColItemCatDisImage, hopefully it works more consistently now. Lmk how it goes with the testing

jwcha1030 commented 3 years ago

Seems to be working great now.