jwdeveloper / JW_Piano

Play piano with your friends
Other
8 stars 1 forks source link

About error and feature additions #5

Closed cats-love closed 2 years ago

cats-love commented 2 years ago

2022-07-29_00 21 40 Hello, this is cats_love using the plugin on the Korean server. I wrote this to talk about some console errors and feature updates.

image First, clicking on the piano within the server causes the console log to go up badly. Is there any way to solve this problem?

Second, we ask if you plan to edit or add translations in the config, if you plan to add multiple piano colors, if you can use org.bukkit.inventory.ItemStack instead of a hoe to change item skins, and more! Working with custommodeldata while making a wooden hoe available?

cats-love commented 2 years ago

image image

There is one more problem, pressing the f key and releasing it will activate and deactivate the pedal. How do I stop interacting with the pedals?

jwdeveloper commented 2 years ago

Hi thank you for bugs report,


First, clicking on the piano within the server causes the console log to go up badly. Is there any way to solve this problem?

This issue is related to multiverse plugin and I'm currently working on fixing it :)

if you can use org.bukkit.inventory.ItemStack instead of a hoe to change item skins

I don't really know if I understand this correctly but you do suggesting to make in config new section for custom skins? like? If so that's a great idea 👍 Unfrotunatelly I need to stick to one item type so propably I just change hoe to less used Item

  custom-skins:
    -new-skin:
      name: brand new piano
      modeldata: 2


edit or add translations I'm consider to include that but It will take so much time to implement so I don't think that will be possible for future updates

multiple piano colors

I feel custom skins section gives you opportunity to make the color as you want
There is one more problem, pressing the f key and releasing it will activate and deactivate the pedal. How do I stop interacting with the pedals?

Pressing pedal on f key is a feature, but I could make it optional
Update ideas:

If you would have more ideas let me know I would love to hear it!

cats-love commented 2 years ago

Also, the tp function is enabled even if there is no permission, so I would like to block it!

cats-love commented 2 years ago

image I want to use custommodeldata like this so that the piano and the wooden hoe do not overlap, but I don't know how..

jwdeveloper commented 2 years ago

hi, Custom skins are not yet implemented, but It will be soon possible

jwdeveloper commented 2 years ago

https://www.spigotmc.org/resources/piano.103490/ New update is avaliable

!Custom skins are not ready yet!