search

jwdj / EasyABC

EasyABC
GNU General Public License v2.0
90 stars 36 forks source link

Feature/midi input unicode #33

Closed marcstober closed 3 years ago

marcstober commented 3 years ago

Fix an issue with parsing MIDI input (from a file or from an actual device like a MIDI keyboard) that has a "broken rhythm" (i.e. the < or > symbols to created dotted notes) in Python3, which was using the Python 2 unicode function. Handle in the same way the code handles the unicode function in other files to be compatible with both Python 2 and 3.

Steps to reproduce:

  1. Create a tune with a broken rhythm, e.g.: C>CCC | C/<C/C3 |]
  2. Export to MIDI.
  3. Try to import the MIDI file - you will get an error. Expect to be able to "round trip."

Note: Reproduced with Python 3.6.4 on Windows 10.

marcstober commented 3 years ago

Note - this is in addition to #32 I submitted earlier today.