jwdj / EasyABC

EasyABC
GNU General Public License v2.0
87 stars 36 forks source link

abc-include fails #56

Open ClintGoss opened 2 years ago

ClintGoss commented 2 years ago

The directives %%abc-include and I:abc-include seem to be implemented (in abc2xml.py), but fail badly (for me, at least). Any used of these directives causes havoc with the parser. For example:

stdin:33:16: error: Bad length
  33 "_Rubato Intro"F2 {c}F3 FAB | B/c3/2 {e}c3 FAc | {Bc}B2 {c}B3 FAB | F8 |
                     ^
stdin:33:22: error: Bad length
  33 "_Rubato Intro"F2 {c}F3 FAB | B/c3/2 {e}c3 FAc | {Bc}B2 {c}B3 FAB | F8 |
                           ^
stdin:33:31: error: Bad length divisor
  33 "_Rubato Intro"F2 {c}F3 FAB | B/c3/2 {e}c3 FAc | {Bc}B2 {c}B3 FAB | F8 |
                                    ^

Also, a much more minor issue: The file location of the included .ABH file is not relative to the source file that issues the abc-include directive - I have to specify fully qualified path names.

Was this directive intended to be implemented? (For me, this is a key feature, since all my .abc files refer to a common .ABH that specifies layout, so I can accommodate many different output formats).