Invalid space map rotation options

jweigelt / swbf2admin

Star Wars Battlefront II (2005) server management application

GNU General Public License v3.0

51 stars 18 forks source link

Invalid space map rotation options #19

Closed netmasa closed 5 years ago

netmasa commented 5 years ago

Hey all,

Slight bug due to how the code is in maps.htm, GCWAss and CWAss both have the "data-map" attribute of "g_ass". This is wrong because CWAss should have "c_ass" and should also say CW Assault.

Because of this, the invalid maps enter rotation incorrectly.

yonilerner commented 5 years ago

@netmasa No pressure, but just in case you werent aware, you can actually suggest these changes yourself in pull requests quite easily. eg:

Go to https://github.com/jweigelt/swbf2admin/blob/master/DebugFiles/web/maps.htm and click the Edit button in the right corner:
Make the change and select the option to create a new branch with the changes:
Then create the pull request:

And then when the repository owner is ready to approve the change, they can merge it in

yonilerner commented 5 years ago

Heres my PR: https://github.com/jweigelt/swbf2admin/pull/20

yonilerner commented 5 years ago

And thanks!

jweigelt commented 5 years ago

Fixed in c74786e5d4726222a52866a4179e6500bf48eaf4