search

jweiland-net / events2

With this TYPO3 extension you can organize one, multiple and recurring events.
GNU General Public License v2.0
18 stars 16 forks source link

[Feature Request] enhancement of NumberedPagination integration #427

Open SvenJuergens opened 1 year ago

SvenJuergens commented 1 year ago

The simplifyPagination Patch for using the numbered_pagination is great. I still have one small wish or suggestion for improvement. Unfortunately you can only pass the "maximumNumberOfLinks" as a ConstructorElement to NumberedPagination and so you have no possibility to customize this setting. It would be great if you could pass an individual value here.

sfroemkenjw commented 1 year ago

Hello @SvenJuergens

I just had a look how EXT:news implement that:

https://github.com/georgringer/news/blob/main/Classes/Controller/NewsController.php#L693-L702

It has individual cases for each Pagination and uses different constructor arguments! The original interface was overwritten with class_alias and the implemented constructor was overwritten with help of default values. That's so damn nasty. Maybe I will find a solution to use ServiceLocators here, but I will not implement the EXT:news solution.

Stefan