search

jweiland-net / video_shariff

This extension provides more privacy when embedding videos in frontend.
https://extensions.typo3.org/extension/video_shariff
Other
5 stars 6 forks source link

[WIP][FEATURE] News partial #25

Closed t3easy closed 3 years ago

t3easy commented 4 years ago

Provide a partial to render videos of ext:news the same way as content elements.

Work in progress, because TypoScript registration like plugin.tx_news.view.partialRootPaths.1526542481 = EXT:video_shariff/Resources/Private/Extensions/fluid_styled_content/Partials/ is missing. The rest of it works.

Maybe we can talk about how to add this. Just documentation, separate TypoScript folder...

Resolves: #24

stephangrass commented 3 years ago

Hey, that's a good feature! And this solution works very well.

t3easy commented 3 years ago

@froemken @pascal20997 Can we talk/write about the missing TypoScript and how you would like to handle this?

pascal20997 commented 3 years ago

Hey Jan, sorry for the late response. The idea is great and I'm happy for that request. What do you think about adding that TypoScript to the main static template of ext:video_shariff. If the user has no news installed, it does not throw an error or so and if the user doesn't want video_shariff for news then he can just disable it by removing the line using TypoScript.

t3easy commented 3 years ago

He Pascal, perfect! I'll add the TypoScript to the PR branch.

pascal20997 commented 3 years ago

Thank you very much :)