search

jweiland-net / video_shariff

This extension provides more privacy when embedding videos in frontend.
https://extensions.typo3.org/extension/video_shariff
Other
5 stars 6 forks source link

Error thrown in JavaScript due to Typo3 adding "noicon"-class #30

Closed uzerterter closed 2 years ago

uzerterter commented 2 years ago

When i installed and tested the extension the while (previewLink.className !== 'video-shariff-play') check failed to stop at the correct element due to Typo3 adding a "noicon"-class to the "video-shariff-play"-element. I wrote a small patch to prevent that from happening: while (!previewLink.className.split(' ').includes('video-shariff-play')) I think this should still work the intended way while being less error-prone.

froemken commented 2 years ago

Hello @uzerterter

thank you to make video_shariff a better extension. I have adopted your patch into version 2.0.2 which was just released for composer at packagist. I will release version 2.0.2 to TER at monday, too.

Have a nice evening

Stefan