search

jwellman80 / ArduinoLightbox

15 stars 17 forks source link

Indilib support and CRLF #1

Open gehelem opened 5 years ago

gehelem commented 5 years ago

Hi, first of all thank for this piece of code I've made a few changes to make it work with indilib, but i've no idea if SGP will support that (asked a couple of friends to try)

Most of my modification is to play around with CRLF (i've also added servo support) Do you mind if i make a pull request ? Tx Gilles.

jwellman80 commented 5 years ago

Sure, put a PR through and I'll try and test that PR. If everything works well we can merge it. If not maybe a separate fork or branch would be best.

Jared

gehelem commented 5 years ago

Ok thanks, i'll do tonight. SGP test is ok. But we had to make a small workaround to make it work with a simple arduino nano : indi is refreshing too fast for it, so we've added a small delay into read from serial. That makes the code working with both indi and SGP, with arduino nano and promicro. Gilles

xthestreams commented 4 years ago

i just realised i submitted a similar fix, would be great to push this through to the trunk!

xthestreams commented 4 years ago

i'm playing with a library to add Bonjour and Ethernet and WiFi support, a little way to go!