search

jwestbrook / bootstrap-prototype

PrototypeJS based Sleek, intuitive, and powerful front-end framework for faster and easier web development.
http://twitter.github.com/bootstrap
Apache License 2.0
24 stars 15 forks source link

Problem after switching between JQuery version and yours... #13

Open Man4x opened 10 years ago

Man4x commented 10 years ago

Hi, As a Magento dev, I'm bound to deal with Prototype and until I found your project, adopting Bootstrap was meaning a hazardous JQuery-Prototype coexistence as an extra http request. Hence was your fork the best news of the year ! Problem is that I don't succeed in replacing the Bootstrap JQuery version with yours. Well... Shame is immense and I'm just considering the possibility to change job... ^^

jwestbrook commented 10 years ago

OK thats good to hear, but I need more details or examples of what is happening. What I wrote is not a drop-in replacement, but it will work with a few adjustments.

Man4x commented 10 years ago

Hi Jason. So nice of you to answer. In fact, I quite messed up the original bootstrap css file with my own modifications but everything remains ok with the JQuery js file. But when I swap with your prototype version, collapsing blocks (for exemple) don't collapse anymore. That's weird. Since I'm just at the beginning of the designing dev for my website, I'm still hesitating between both the solutions, even if yours would obviously be the better one. If you have time, you can have a look at http://devel.nicoflash.cbi.nbs-test.com but for sure I'd understand you have one thousand things far more urgent to do. Anyways, many thanks for your attention and your open source project.

Ps: sorry for my english and my writting; quite hard to write in english with a french iPhone that is proposing me the whole french dictionnary every time I hit a letter ! ^^

Le 30 avr. 2014 à 22:33, "Jason Westbrook" notifications@github.com a écrit :

OK thats good to hear, but I need more details or examples of what is happening. What I wrote is not a drop-in replacement, but it will work with a few adjustments.

— Reply to this email directly or view it on GitHub.

jwestbrook commented 10 years ago

I think you might have a problem with the PrototypeJS version. Currently it looks like you are running 1.7. I developed this with 1.7.1 and the latest is 1.7.2. Can you try and upgrade your prototype file to at least 1.7.1?

Man4x commented 10 years ago

Ok Jason, I'm gonna try with the updated Proto version and let you know. (I'm considering your kindness as twice for answering me a first of may ^^)

Le 1 mai 2014 à 15:53, "Jason Westbrook" notifications@github.com a écrit :

I think you might have a problem with the PrototypeJS version. Currently it looks like you are running 1.7. I developed this with 1.7.1 and the latest is 1.7.2. Can you try and upgrade your prototype file to at least 1.7.1?

— Reply to this email directly or view it on GitHub.

Man4x commented 10 years ago

Hi Jason. I updated the Prototype version to 1.7.2 but it doesn't do better. It's strange; when I click on the block title ("Votre espace client" on the left-sided column), it doesn't work at all but if I click on the very edge of the block (i.e. in the div itself but not in the strong tag included in it), the css class of the block to collapse is actually updated with "collapse" and "in" classnames. When I click again then, the "in" classname is correctly removed and the block "pseudo-collapses" but all its content remains displayed. Very weird. PS: I'm testing on Firefox 28 with Firebug

jwestbrook commented 10 years ago

OK I see what is happening, I've committed a fix to prevent the extra elements in the click space from causing a problem, but I think you have an element in the collapsible element that has a set height that is breaking the behavior. I'll see if I can replicate that problem as well.

Man4x commented 10 years ago

Well, happy to see that this doesn't surprise you. Is my HTML code responsible for this kind of issue ? It´s was OK with the JQuery version anyway.

Le 3 mai 2014 à 17:04, "Jason Westbrook" notifications@github.com a écrit :

OK I see what is happening, I've committed a fix to prevent the extra elements in the click space from causing a problem, but I think you have an element in the collapsible element that has a set height that is breaking the behavior. I'll see if I can replicate that problem as well.

— Reply to this email directly or view it on GitHub.