search

jwg4 / flask-selfdoc

Flask-selfdoc automatically creates an online documentation for your flask application.
MIT License
18 stars 4 forks source link

Jinja dependency #69

Closed sergiokessler closed 1 year ago

sergiokessler commented 2 years ago

Jinja2 dependency should be added so is automatically pulled

jwg4 commented 1 year ago

Isn't Jinja2 a dependency of Flask?

jwg4 commented 1 year ago

The incompatibility between certain versions of Flask and certain versions of Jinja appears to have been an error by @davidism, the maintainer of both projects, who doubled down on his error by explaining to multiple people that he had done nothing wrong and that it was their own fault for not pinning specific versions. I didn't come to a clear understanding of what library maintainers should do, other than change their deps to only support more recent Flask versions.

I believe that he went on to close and delete all the bug reports and discussions about this common issue on both github projects. I was surprised by a lot of his behavior around this, particularly as he seems to be the principal maintainer of these two excellent projects.

I have no current plans to untangle this nonsense, but I will take a patch if someone else wants to, providing there is a clear explanation of why it solves the problem and maximizes compatibility of Flask-Selfdoc with Flask and Python versions.

sergiokessler commented 1 year ago

Sorry to come late to this, but no, Jinja2 is not a dependency of Flask (and should not be IMO). For example, if you use Flask for developing an API, you don't need Jinja2 at all.

jwg4 commented 1 year ago

Jinja2 certainly is a dependency of Flask.

skessler-incucai commented 1 year ago

hmm, I can assure you I'm using flask with no jinja installed just fine (I installed it because of selfdoc, but later uninstalled both things)

jwg4 commented 1 year ago

Yes, that's not the definition of a dependency.

On Mon, 26 Dec 2022, 13:30 skessler-incucai, @.***> wrote:

hmm, I can assure you I'm using flask with no jinja installed just fine (I installed it because of selfdoc, but later uninstalled both things)

— Reply to this email directly, view it on GitHub https://github.com/jwg4/flask-selfdoc/issues/69#issuecomment-1365182474, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGTQCHR26WD6OFCX4OZULLWPGMZFANCNFSM5VZXOGJA . You are receiving this because you modified the open/close state.Message ID: @.***>