search

jwgalvin / mod_0_assesment

0 stars 0 forks source link

Assessment Results #1

Open corneliusellen opened 2 years ago

corneliusellen commented 2 years ago

@jwgalvin I just went over your assessment and there are some changes that I’d like for you to make before we consider you technical ready. Please have them done by EOD Wednesday (11/17) and send me a slack message once completed.

jwgalvin commented 2 years ago

fixed the variables in the hash for model_a.rb.

thanks for the note!

On Mon, Nov 15, 2021 at 2:42 PM Ellen Cornelius @.***> wrote:

@jwgalvin https://github.com/jwgalvin I just went over your assessment and there are some changes that I’d like for you to make before we consider you technical ready. Please have them done by EOD Sunday and send me a slack message once completed.

  • It is Ruby convention to use snake_case when naming hash keys

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jwgalvin/mod_0_assesment/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV523EBI7XCXA4OMXORGSLTUMF5GDANCNFSM5ICW44XQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Producer, Director, Comedy Guy