search

jwhitley / requirejs-rails

RequireJS support for your Rails 3 or 4 application
MIT License
592 stars 202 forks source link

logical_asset_filter #229

Closed merqlove closed 9 years ago

merqlove commented 9 years ago

Seems that this implementation is wrong for now:

config.requirejs.logical_asset_filter += [/\.hamlbars/]

Unknown + method.

merqlove commented 9 years ago

Yes, seems that for now it is: logical_path_patterns

carsomyr commented 9 years ago

@merqlove Sorry about that; didn't think that users would externally modify that value. Are you cool with using logical_path_patterns? What does the rest of the Rails codebase say about naming conventions?

merqlove commented 9 years ago

@carsomyr Yes, it works fine for me :+1: I use some custom template engines, like handlebars/hamlbars. Speech above is about: logical_asset_filter unavailable from 2-3 latest releases ago. logical_path_patterns works fine => README :100:

carsomyr commented 9 years ago

@merqlove Alright, but if you can think of Rails naming conventions with regards to other, similar kinds of config values, let me know.