Closed merqlove closed 8 years ago
For now seems that it stable. Tests passed.
Maybe a generic solution is better. What to think about a check like this:
if defined?(super)
super_method.arity == 1 ? ? super(source) : super
else
view_proxy.javascript_path(source, options)
end
We can't do this, super_method
in Ruby from 2.2+.
Sorry, you are right.
Looking to the code I don't see a case that the options
are used.
I think we could remove this params.
def javascript_path(source)
if defined?(super)
super
else
view_proxy.javascript_path(source)
end
end
I don't think so. Because this is what we use as helper. We cannot just delete it, this is View API of rjs-rails. :)
When you put requirejs_include_tag
into the view, ActionView will use this method.
This PR was did 5 month ago. Problem still actual. So?
@merqlove Sorry for letting this fall through the cracks. I'll issue a minor release tonight.
@carsomyr Ok. Anyway Rails 3 not working with Sprockets 3, as someone mentioned in #247
@merqlove How does 78d43f2 look?
@carsomyr Thanks, looks good!
210