IceDragon200
commented
8 years ago @samstarling I had a similar issue some time back, try downgrading your version of sprocket-rails to 2.x, that fixed it for me
Open samstarling opened 8 years ago
IceDragon200
commented
8 years ago @samstarling I had a similar issue some time back, try downgrading your version of sprocket-rails to 2.x, that fixed it for me
samstarling
commented
8 years ago @IceDragon200 You're right - downgrading sprockets-rails to 2.3.3 fixed this.
AntiFish03
commented
8 years ago This seems to be the issue. https://github.com/rails/sprockets-rails/issues/237
carsomyr
commented
8 years ago Thanks all for the reports. I'm looking to have a fix out in the upcoming week.
jankeesvw
commented
8 years ago I have the same issue... Hope this can get fixed!
jankeesvw
commented
8 years ago I'm running still running into this problem, I upgraded Rails to 4.2.6 which depends on sprockets (>= 3.0.0). Is there a way to hotfix this so I can deploy my security updates?
jankeesvw
commented
8 years ago When I try to downgrade sprockets-rails to 2.3.3 I run into these kinds of errors:
Bundler could not find compatible versions for gem "tilt":
In snapshot (Gemfile.lock):
tilt (= 2.0.1)
In Gemfile:
haml was resolved to 4.0.7, which depends on
tilt
sass-rails (~> 5.0) was resolved to 5.0.4, which depends on
tilt (< 3, >= 1.1)
delayed_job_web was resolved to 1.2.10, which depends on
sinatra (>= 1.4.4) was resolved to 1.4.6, which depends on
tilt (< 3, >= 1.3)
sprockets (= 2.3.3) was resolved to 2.3.3, which depends on
tilt (!= 1.3.0, ~> 1.1)
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.I tried downgrading a lot of gems, but bundler can't seem to solve the dependency issues. @carsomyr are you working on a fix? I would love to help!
carsomyr
commented
8 years ago All, I've been very busy lately delivering a major feature. I'll try to look into this on Saturday.
jankeesvw
commented
8 years ago No problem @carsomyr, if you need a hand let me know. For now I removed this Gem and switched to using plain require-js, so the urgency is gone for me.
matfiz
commented
8 years ago You can replace Raiils.application.assets with Rails.application.assets_manifest.files.values.map{|v| v['logical_path']} (ref. https://github.com/rails/sprockets-rails/blob/6f5a37cfc7e5e71e2a7e1d1c002448dc374f1324/lib/sprockets/railtie.rb#L142-L148)
jankeesvw
commented
8 years ago @matfiz thanks for the comment. But what do you mean? Where should I replace this?
jankeesvw
commented
8 years ago I got this result for the manifest files:
>> Rails.application.assets_manifest.files
=> {}@jankeesvw have you checked in production env?
jankeesvw
commented
8 years ago @matfiz no only in development mode, how do you overwrite this? Add something to an initializer?
matfiz
commented
8 years ago The assets_manifest reads the Sprockets manifest file from compiled assets - these are available only in production. AFAIK you can emulate it in development by setting config.assets.compile = false in development.rb.
jankeesvw
commented
8 years ago Thanks for the quick response @matfiz, can you give me an concrete example of how we can fix this error?
jankeesvw
commented
8 years ago Hi @matfiz, would be great if you have some more information on your proposed solution! Thanks! :sparkles:
ijdickinson
commented
8 years ago I've just run into this issue as well. Is there any update on suggested resolutions?
jankeesvw
commented
8 years ago Is there someone with a solution / work around?
ijdickinson
commented
8 years ago @jankeesvw I switched my app to using modulejs instead of requirejs, following this pattern:
https://reinteractive.net/posts/172-a-better-way-to-modularise-your-js-in-rails
It has been working well for me, and fits more comfortably into the asset pipeline.
jankeesvw
commented
8 years ago @ijdickinson that looks good! Did it require a lot of rewriting?
I would rather not rewrite the app, there is quite some JavaScript in my application.
ijdickinson
commented
8 years ago @jankeesvw No, it was very straightforward. The signature for the modulejs require function is almost the same as the requirejs require, and then you need to rely on the asset pipeline to load the JavaScript manifest in the usual way - modulejs doesn't do any file management like requirejs does. Modulejs isn't nearly as capable as requirejs, so if you're relying on aliasing and those kinds of advanced features it won't help you.
We probably shouldn't continue this discussion in this issue thread - it's going a bit off-topic. Please feel free to pm me if you want more details!
thegillis
commented
8 years ago For me this appeared to be a problem with a sprockets upgrade. We needed to upgrade to sprockets 3 and there were multiple errors related to asset precompile.
The cause of the actual error is essentially that it's trying to access:
Rails.application.assets.paths.dupUnfortunately in sprockets along the way this no longer works. Instead of accessing application.assets.path, the valid location now appears to be application.config.assets.
Although this was able to get us further, there are many more sprockets problems. I'll see if I can clean things up a bit and test my changes against sprockets 2, but my company is now using:
https://github.com/MediaFactual/requirejs-rails/tree/rails5-1-0-0
or with bundler:
gem 'requirejs-rails', :git => 'https://github.com/MediaFactual/requirejs-rails.git', :branch => 'rails5-1-0-0'
If these changes appear to be stable on our systems, I'll submit a pull request.
I'm getting the following error after upgrading from Rails 4.2.5 to 4.2.5.1.
Any ideas what might be wrong?